Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default installation #292

Merged
merged 4 commits into from
Feb 5, 2021
Merged

Conversation

NandoTheessen
Copy link
Contributor

Hi everyone 👋🏻

Due to the failing hook, an installation w/ default values is impossible at the moment.
I appreciate this is only one of the two routes we could take to fix this issue.

I've chosen this route because I think it isn't necessary to have 6 click house pods running with the default install.

Fixes issue #283

@Mokto
Copy link
Contributor

Mokto commented Feb 3, 2021

Hey, thanks! I never had any issue, but I can understand.

I think we need:

  1. To make this configurable ?
  2. To increment the major version, as this is a breaking change.

@NandoTheessen
Copy link
Contributor Author

Hey @Mokto thanks for the super quick answer 😄

re 1: This should already be configurable in the clickhouse chart, for me this works out of the box. Is that what you meant?
re 2: Makes sense! 💡

@Mokto
Copy link
Contributor

Mokto commented Feb 5, 2021

My next answer is not that fast ;) Thanks for your answer, I'll merge & create a major release now.

@Mokto Mokto merged commit 45cc76d into sentry-kubernetes:develop Feb 5, 2021
This was referenced Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants