Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass symbolicator config as YAML #335

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Pass symbolicator config as YAML #335

merged 2 commits into from
Mar 23, 2021

Conversation

philicious
Copy link
Contributor

This adds more config options to symbolicator deployment.

We needed connect_to_reserved_ips , which wasnt supported, so I took the chance and added more along the way.

I tested symbolicator to start properly also with the caches enabled

@philicious philicious changed the title Add more config options to symbolicator Pass symbolicator config as YAML Mar 21, 2021
@philicious philicious requested a review from Mokto March 21, 2021 22:31
@philicious
Copy link
Contributor Author

@Mokto I could add some smybolicator paragraph to README as it wasnt totally straight-forward to get it working, like

        filestore:
          filesystem:
            persistence:
              persistentWorkers: true

but also needed to set connect_to_reserved_ips: true

maybe its even worth changing connect_to_reserved_ips to default true?

@Mokto
Copy link
Contributor

Mokto commented Mar 22, 2021

I agree with both.

I'll let you update your PR and then I'll merge it.

Thanks!

@philicious
Copy link
Contributor Author

updated README and also default value of connect_to_reserved_ips @Mokto

sentry/README.md Outdated Show resolved Hide resolved
@Mokto
Copy link
Contributor

Mokto commented Mar 23, 2021

Thaaaanks ! 👍

@Mokto Mokto merged commit 20d23b5 into sentry-kubernetes:develop Mar 23, 2021
This was referenced Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants