suppot partitions parameter for consumer events #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Could you also update the minor version ? |
|
@Mokto |
|
Sorry but you updated the patch version. As you added a new feature, I'd like the minor version to be updated. Thanks! |
This reverts commit f873faa.
|
Oh... |
|
Perfect, thanks! |
Mokto
pushed a commit
that referenced
this pull request
Jun 7, 2022
snuba-subscription-consumer-transactions requires same fix as #566 when running with partitioned topic.
This was referenced Apr 12, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: https://forum.sentry.io/t/perfomance-metric-alarm-related-to-snuba-events-subscriptions-consumers-snuba-transactions-subscriptions-consumers/15102
Hi!
sentry-snuba-subscription-consumer-events expect partition of kafka topic is 1,but kafka should has some partition if you want to fault tolerance.
So I add paramter for kafka partition.
thanks.