feat: add podLables to Sentry hooks #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The init jobs do not have unique podLables The lables can be used for mapping these init jobs with services Use case: To allow access to services inside Consul mesh, a service is needed.
nishaero
changed the title
Mokto
reviewed
Jul 7, 2022
sentry/values.yaml
Outdated
| @@ -456,6 +459,8 @@ hooks: | |||
| affinity: {} | |||
| nodeSelector: {} | |||
| # tolerations: [] | |||
| snubaMigrate: | |||
There was a problem hiding this comment.
Don't you need to use snubaMigrate: {}?
There was a problem hiding this comment.
Don't you need to use
snubaMigrate: {}?
Yes, I have added it. Thank You :)
There was a problem hiding this comment.
I have bumped the chartversion to 15.0.1 this should fix the lint issue
Mokto
approved these changes
Jul 7, 2022
Mokto
approved these changes
Jul 27, 2022
This was referenced Apr 12, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The init jobs do not have unique podLables
The lables can be used for mapping these init jobs with services
Use case: To allow access to services inside
Consul mesh, a service is needed.