Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor directory and namespace #90

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Refactor directory and namespace #90

merged 3 commits into from
Mar 23, 2021

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Mar 22, 2021

No description provided.

@at-wat at-wat self-assigned this Mar 22, 2021
@sqbot
Copy link
Member

sqbot commented Mar 22, 2021 •
edited
Loading

[20] PASSED on kinetic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 31 tests, 0 errors, 0 failures, 0 skipped

[20] PASSED on melodic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 31 tests, 0 errors, 0 failures, 0 skipped

[20] PASSED on noetic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 31 tests, 0 errors, 0 failures, 0 skipped

@codecov
Copy link

codecov bot commented Mar 22, 2021 •
edited
Loading

Codecov Report

Merging #90 (9003f8f) into master (de101b1) will not change coverage.
The diff coverage is n/a.

❗ Current head 9003f8f differs from pull request most recent head e8773d6. Consider uploading reports for the commit e8773d6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   88.26%   88.26%           
=======================================
  Files          13       13           
  Lines         230      230           
=======================================
  Hits          203      203           
  Misses         27       27
Impacted Files Coverage Δ
include/urg_stamped/device_time_origin.h 100.00% <ø> (ø)
include/urg_stamped/first_order_filter.h 100.00% <ø> (ø)
include/urg_stamped/timestamp_moving_average.h 100.00% <ø> (ø)
include/urg_stamped/timestamp_outlier_remover.h 100.00% <ø> (ø)
test/src/test_device_time_origin.cpp 100.00% <ø> (ø)
test/src/test_first_order_filter.cpp 100.00% <ø> (ø)
test/src/test_timestamp_moving_average.cpp 100.00% <ø> (ø)
test/src/test_timestamp_outlier_remover.cpp 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de101b1...e8773d6. Read the comment docs.

@at-wat at-wat requested a review from nhatao March 23, 2021 00:47
@at-wat
Copy link
Member Author

at-wat commented Mar 23, 2021

@nhatao please take a look

@at-wat at-wat mentioned this pull request Mar 23, 2021
Merged
nhatao
nhatao approved these changes Mar 23, 2021
View reviewed changes
Copy link

@nhatao nhatao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It would be better to update years in copyrights.

src/urg_stamped_node.cpp Outdated
@@ -0,0 +1,30 @@
/*
* Copyright 2018-2019 The urg_stamped Authors
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018-2021

include/urg_stamped/urg_stamped.h Outdated
@@ -0,0 +1,158 @@
/*
* Copyright 2018-2019 The urg_stamped Authors
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@sqbot
Copy link
Member

sqbot commented Mar 23, 2021 •
edited
Loading

[22] PASSED on melodic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 31 tests, 0 errors, 0 failures, 0 skipped

[22] PASSED on kinetic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 31 tests, 0 errors, 0 failures, 0 skipped

[22] PASSED on noetic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 31 tests, 0 errors, 0 failures, 0 skipped

@sqbot
Copy link
Member

sqbot commented Mar 23, 2021 •
edited
Loading

[23] PASSED on kinetic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 31 tests, 0 errors, 0 failures, 0 skipped

[23] PASSED on noetic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 31 tests, 0 errors, 0 failures, 0 skipped

[23] PASSED on melodic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 31 tests, 0 errors, 0 failures, 0 skipped

@at-wat at-wat merged commit 12b3983 into master Mar 23, 2021
@at-wat at-wat deleted the refactor-dir-and-ns branch March 23, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhatao nhatao nhatao approved these changes

Assignees

@at-wat at-wat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@at-wat @sqbot @nhatao