Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lint for HashMap iteration #424

Open
kayabaNerve opened this issue Nov 10, 2023 · 1 comment
Open

Add lint for HashMap iteration #424

kayabaNerve opened this issue Nov 10, 2023 · 1 comment
Labels
CI/CD Continuous integration workflows improvement This could be better

Comments

@kayabaNerve
Copy link
Member

rust-lang/rust#92584 created a compiler-internal lint for unstable iterations over HashMaps. Ideally, we can lift it into https://github.com/trailofbits/dylint and run it over Serai to ensure we aren't expecting stable iteration from something with an unstable insertion order.

I also requested this as a clippy lint in rust-lang/rust-clippy#11788.
@kayabaNerve kayabaNerve added improvement This could be better CI/CD Continuous integration workflows labels Nov 10, 2023
@kayabaNerve
Copy link
Member Author

Just waiting for the above clippy to hit nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/CD Continuous integration workflows improvement This could be better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kayabaNerve