Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding name conflicts #5

Closed
sethaxen opened this issue Oct 28, 2022 · 2 comments · Fixed by #15
Closed

Avoiding name conflicts #5

sethaxen opened this issue Oct 28, 2022 · 2 comments · Fixed by #15
Labels
discussion enhancement New feature or request

Comments

@sethaxen
Copy link
Owner

Simple function names like name are likely to collide with variable names or other methods in the user's scope. We may want to consider turning all function names into verbs. e.g. by prepending with get (or get_). e.g.

  • model -> getmodel or get_model
  • info -> getinfo or get_info
  • name -> getname or get_name
@sethaxen
Copy link
Owner Author

sethaxen commented Nov 4, 2022

I've decided to employ the get_ prefix and will update the API accordingly.

@sethaxen
Copy link
Owner Author

sethaxen commented Nov 7, 2022

Mmm, I really didn't like all the get_s. I'll hold off on this change until a user tells me it's a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant