Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS needs updating rsync to work #10

Closed
TriplEight opened this issue Nov 19, 2019 · 7 comments
Closed

MacOS needs updating rsync to work #10

TriplEight opened this issue Nov 19, 2019 · 7 comments

Comments

@TriplEight
Copy link
Contributor

The thing what really helped cargo-remote to work on macos is

brew install rsync

The patch #3 didn't help at all. Neither before nor after brew install rsync.
Please follow @kianenigma advice there.

@sgeisler
Copy link
Owner

Ok, but did #3 break anything? I'm not a Mac user, so I can't test this. But I'll add a remark to the README. Do Mac devs know what brew is or should I link to somewhere?

@kianenigma
Copy link

Do Mac devs know what brew is or should I link to somewhere?

a Dev should know what it is I suppose.

Ok, but did #3 break anything? I'm not a Mac user, so I can't test this.

I just compiled and linked the latest master and it still works fine for me, given the updated rsync. Though I don't get colored output so I will revert.

@sgeisler
Copy link
Owner

sgeisler commented Nov 21, 2019

So #3 broke the coloring and it worked before? Then I don't understand @TriplEight's comment in #3 tbh. If that's the case I'll revert #3 too.

@kianenigma
Copy link

Yeah don't know why. Maybe it is the wasm runner that does not show them?
Screenshot 2019-11-21 at 10 55 01

@kianenigma
Copy link

also the progress bar is gone for some reason

@sgeisler
Copy link
Owner

sgeisler commented Nov 21, 2019

Did you test with the pre-#3 version too?

Ah, I see it's about cargo and shouldn't be affected by #3. Were you running a version with the #9 patch?

@TriplEight
Copy link
Contributor Author

So #3 broke the coloring and it worked before? Then I don't understand @TriplEight's comment in #3 tbh. If that's the case I'll revert #3 too.

I also don't have a Mac to test on, was asking colleagues to do that xD

TriplEight referenced this issue in paritytech/cargo-remote Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants