Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 114: [WIP] count_allele_calls #205

Closed
quansight-bot opened this issue Aug 27, 2020 · 0 comments
Closed

PR 114: [WIP] count_allele_calls #205

quansight-bot opened this issue Aug 27, 2020 · 0 comments

Comments

@quansight-bot
Copy link

Pull request metadata

Pull request description

See issue #85

This implements an additional jitted function count_call_alleles_ndarray_jit for ndarrays only rather than doing it all in dask.
This approach seems to be inline with the goals outlined here but I'm happy to replicate the approach of the original count_alleles function if that is preferred.

Likewise I can re-write count_alleles using this approach which should improve performance (mainly on chucked arrays due to njit(..., nogil=True))

I haven't added numba to requirements.txt or setup.py Because that is done in #76

I guess add numba now for CI and fix conflict later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant