Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unneeded vendor packages in glide.lock are kept #14

Closed
sgotti opened this issue Jun 1, 2016 · 2 comments
Closed

Unneeded vendor packages in glide.lock are kept #14

sgotti opened this issue Jun 1, 2016 · 2 comments
Milestone

Comments

@sgotti
Copy link
Owner

sgotti commented Jun 1, 2016

The glide.lock file may contain unneeded packages. This can happen with unneeded entries in glide.yaml or with not fine grained ones (for example having just github.com/coreos/etcd when only the github.com/coreos/etcd/client pkg is needed will have a glide.lock entry with a lot of etcd packages not needed by the project)

A way to get the real needed pkgs list will be to use the glide list json output. But, since we want to also keep the base package license files, there's the need to also get the base package path. Actually this isn't exported so a solution will be to recycle the glide functions that do this, but this is suboptimal.

@sgotti
Copy link
Owner Author

sgotti commented Jun 3, 2016

Probably we could just use the glide list output to get the needed packages and the glide.lock to retrieve the base package path.

@sgotti
Copy link
Owner Author

sgotti commented Sep 24, 2016

Resolved by #21

@sgotti sgotti closed this as completed Sep 24, 2016
@sgotti sgotti modified the milestone: v0.1.0 Sep 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant