You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ericchiang I think this is the same thing that i tried to explain in the README
In #21 glide-vc moved from using the glide.lock to the glide list output to determine required packages. A solution will be to use the previous logic passing --use-lock-file.
Another solution will be to use a dummy go file that underscore imports the packages so they will be detected as needed also if no code is used (see #21 (comment)), also rkt, in the past, used a dummy.go to keep vendored CNI plugins.
There are also some subtle cases like #18 where I can't see an easy solution without revendoring them after running glide-vc.
@ericchiang But probably, as you proposed, an additional flag that will also keep packages explicitly defined in glide.yaml (instead of all the packages listed in the generated glide.lock) could be a good mid way solution.
Issue:
Projects sometime vendor
main
packages no directly imported by any code in the project. For example one of my projects vendors a go protoc plugin[0].However, because these aren't imported directly, glide-vc removes them from the
vendor
directory,Proposal:
If mains are explicitly declared as packages or sub packages, include them when determining if a package is imported.
[0] https://github.com/coreos/dex/blob/3c9ab50ddf05b07b74cda1777df6addf9ff44dfe/glide.yaml#L125
The text was updated successfully, but these errors were encountered: