Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish v4.0.0 code on GitHub #181

Open
mrcasals opened this issue Mar 3, 2021 · 2 comments
Open

Publish v4.0.0 code on GitHub #181

mrcasals opened this issue Mar 3, 2021 · 2 comments

Comments

@mrcasals
Copy link

mrcasals commented Mar 3, 2021

Hi, @sgruhier

It looks like a version 4.0.0 of this gem was published, but the code is not yet on GitHub. Could you push the code?

Here's a diff of the code in Rubygems between versions v3.0.0 and v4.0.0:

https://my.diffend.io/gems/foundation_rails_helper/3.0.0/4.0.0

Thanks!

@werebus
Copy link
Contributor

werebus commented Jan 2, 2022

As far as I can see, the only code change in 4.0.0 on rubygems.org that isn't yet on master in this repository is the following:

diff --git a/lib/foundation_rails_helper/version.rb b/lib/foundation_rails_helper/version.rb
index 91d3d74..b6a18bf 100644
--- a/lib/foundation_rails_helper/version.rb
+++ b/lib/foundation_rails_helper/version.rb
@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FoundationRailsHelper
-  VERSION = '3.0.0'
+  VERSION = '4.0.0'
 end

That is, the version bump produced by the gem release process hasn't made its way here, but you aren't missing any bug fixes or features or anything.

@alecslupu
Copy link
Contributor

@werebus, i can confirm that the only difference between V4 on rubygems and master version from here is the Version Bump commit.

Does anyone has that particular commit and is willing to push it to repo, so we can have all the code public?

cc @sgruhier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants