Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_generic_get_bytes #236

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Conversation

oittaa
Copy link
Contributor

@oittaa oittaa commented Mar 6, 2021

Some serializers, like JSON, don't support byte strings and those need to be handled as a special case. It might be useful to test for that anyway.

Some serializers, like JSON, don't support byte strings and those need to be handled as a special case. It might be useful to test for that anyway.
@codecov-io
Copy link

codecov-io commented Mar 6, 2021

Codecov Report

Merging #236 (6ace510) into master (3eddad1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   85.28%   85.31%   +0.02%     
==========================================
  Files          21       21              
  Lines        2624     2629       +5     
==========================================
+ Hits         2238     2243       +5     
  Misses        386      386              
Flag Coverage Δ
unittests 85.31% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_backend_cache.py 93.96% <100.00%> (+0.07%) ⬆️
flask_caching/__init__.py 88.29% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eddad1...6ace510. Read the comment docs.

@sh4nks sh4nks merged commit 9818aa8 into pallets-eco:master Mar 17, 2021
@sh4nks
Copy link
Collaborator

sh4nks commented Mar 17, 2021

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants