Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations #198

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Conversation

MartinThoma
Copy link
Contributor

See issue #197

@coveralls
Copy link

coveralls commented Oct 15, 2020

Coverage Status

Coverage increased (+0.09%) to 79.114% when pulling 4312913 on MartinThoma:issue-197-initial into 0ee6b4a on sh4nks:master.

@sh4nks
Copy link
Collaborator

sh4nks commented Dec 18, 2020

Sorry for getting back to your PR so late. Looks good, however there appears to a conflict with current master. Could you rebase you PR against the latest master?

@MartinThoma
Copy link
Contributor Author

@sh4nks No problem; I've rebased and pushed again :-)

@MartinThoma
Copy link
Contributor Author

I've also added the Typing :: Typed trove classifier

@sh4nks sh4nks merged commit 82fa1d5 into pallets-eco:master Dec 18, 2020
@sh4nks
Copy link
Collaborator

sh4nks commented Dec 18, 2020

Thanks!

@hnicholson-Ocient
Copy link

@MartinThoma do these changes work for mypy? I have started using mypy in my project which is using v1.10.1 of this package, which includes these changes. mypy complains with

cache.py:3: error: Skipping analyzing 'flask_caching': found module but no type hints or library stubs

Based on the mypy docs, packages need to both have types, and declare themselves to be pep 561 compliant (or registered themselves on typeshed ).

I can create an issue for this, I just wanted to check if you had this working in mypy for you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants