Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.3.5 Map Error #243

Open
Bennylavaa opened this issue Sep 25, 2024 · 9 comments
Open

3.3.5 Map Error #243

Bennylavaa opened this issue Sep 25, 2024 · 9 comments

Comments

@Bennylavaa
Copy link
Contributor

make your map small like this using the down arrow thing in the top right corner of the map use reloadui or log out and back in then go to your quest log and click the show button the client freaks out. I am using elvui here but it happens using the default blizzard ui. Keep in mind if you opened the small map and make it visible prior to clicking show it works as youd expect.

image
image

@shagu
Copy link
Owner

shagu commented Sep 26, 2024

I'm unable to reproduce that on wotlk with only pfQuest loaded

@Bennylavaa
Copy link
Contributor Author

Bennylavaa commented Sep 26, 2024

Weird I can reproduce it on the latest build with no other addons enabled. This is on chromiecraft.

  1. Open the map
  2. make it small
  3. /reload
  4. DO NOT OPEN THE MAP (if you do it will work fine)
  5. Open the Quest Log
  6. Click show on one of your quests
  7. Get Error

https://www.loom.com/share/d8e5e8342ac847d1b5f447116d970e9e

I might need to remake the video as its taking forever to process.

Edit: updated the video it works now

@shagu
Copy link
Owner

shagu commented Sep 26, 2024

Screencast_20240926_181938.webm

@Bennylavaa
Copy link
Contributor Author

Bennylavaa commented Sep 26, 2024

@shagu I notice your map isnt showing the quest tracker inside of it like most 3.3.5 servers.

Screenshot 2024-09-26 at 12 24 41 PM

What server are you testing on? I wonder if this could be why?

@shagu
Copy link
Owner

shagu commented Sep 26, 2024

Note: For future reference, here's the UI-Code that throws the error:
https://github.com/Gethe/wow-ui-source/blob/3.3.5/FrameXML/WorldMapFrame.lua#L747-L751

I don't know why :GetCenter() returns nil for you but not for me. pfQuest doesn't hook the WorldMapButton_OnUpdate function and it also doesn't change the position of it.

@shagu
Copy link
Owner

shagu commented Sep 26, 2024

@shagu I notice your map isnt showing the quest tracker inside of it like most 3.3.5 servers.
Screenshot 2024-09-26 at 12 24 41 PM

What server are you testing on? I wonder if this could be why?

Rising-Gods. But it doesn't matter if I enable it or not. I tried it several times with and without the objectives.
It's also not a server setting, it's the checkbox at the worldmap that you are referring to:

image

@shagu
Copy link
Owner

shagu commented Sep 26, 2024

The client I use is enGB, but also tried on deDE with the following build informations:
image

@Bennylavaa
Copy link
Contributor Author

image
Mine is enUS and that is the only difference.

@Bennylavaa
Copy link
Contributor Author

Bennylavaa commented Sep 26, 2024

just some more info ive downloaded a fresh chromiecraft client with all default settings and it has the same issue. So I downloaded a enGB client from https://wowdl.net/client/World-of-Warcraft-3.3.5a.12340 and I have the same issue with that as well so I guess we wait to see if someone else can reproduce this as well.

In both of these tests I downloaded a fresh pfquest from here: https://github.com/shagu/pfQuest/archive/refs/heads/master.zip and named it pfQuest-wotlk which was the only addon I installed also both clients I had all the default base settings.

chromies was enUS and the wowdl was enGB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants