Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing bending line color by default #41

Closed
ceremcem opened this issue Sep 11, 2018 · 13 comments
Closed

Changing bending line color by default #41

ceremcem opened this issue Sep 11, 2018 · 13 comments

Comments

@ceremcem
Copy link
Contributor

For helping mechanical operations, it would be nice to have bending lines in different color on unfold.

@shaise
Copy link
Owner

shaise commented Sep 11, 2018

I Agree. Unfortunately freeCad sketch has no option for separate line colors.

@easyw
Copy link
Contributor

easyw commented Sep 11, 2018

it would be nice to separate the sketches like in commercial sw:

  1. the unfold external outline
  2. the fold lines
  3. the holes/internal cuts

then different colors can be handled too.

https://forum.freecadweb.org/viewtopic.php?f=21&t=30000#p247481
https://forum.freecadweb.org/viewtopic.php?f=3&t=28331&p=241213#p229724
https://forum.freecadweb.org/viewtopic.php?f=3&t=27928&p=252918#p252891

@shaise
Copy link
Owner

shaise commented Sep 11, 2018

I thought about this solution. (it is similar to what I did on Path Simulator)
I did not want to generate too much objects on the tree view. However, perhaps I will add a check box to the unfolder task letting the user decide if to generate separate sketches.
This will at least separate the bend lines. For the internal features to be separate I need Ulrich's help.

shaise added a commit that referenced this issue Sep 15, 2018
Support separate color for bend lines (issue #41)
@shaise
Copy link
Owner

shaise commented Sep 15, 2018

Done.
(At least for bend lines)

@ceremcem
Copy link
Contributor Author

Where do we set "bend lines color"?

@shaise
Copy link
Owner

shaise commented Sep 15, 2018

Right now there is no way. Is this a real need?

@ceremcem
Copy link
Contributor Author

I can't say that it's blocker, but yes, it would remove the great burden of updating unfolded output.

@shaise
Copy link
Owner

shaise commented Sep 15, 2018

OK.
Added color selection as well.

@ceremcem
Copy link
Contributor Author

ceremcem commented Sep 16, 2018

To remove any misunderstanding, I meant the following lines:

image

If there is no misunderstanding, I have to say I didn't find the place to set the default bend line color. I've looked into

  • menu
  • tools/edit parameters/workbench/...
  • tools/edit parameters/preferences/mod/...

@shaise
Copy link
Owner

shaise commented Sep 16, 2018

When you open the unfold task now, you see the colors on the side and you can change it.

@ceremcem
Copy link
Contributor Author

Now I see it, thanks! (FreeCAD warns users that FreeCAD should be re-opened after a first WB install, but it doesn't warn for WB updates. That might be the cause)

@ceremcem
Copy link
Contributor Author

Unfortunately changed line colors are not meaningful until the TechDraw preserves the line colors while generating projections: WandererFan/FreeCAD-TechDraw#64

@shaise
Copy link
Owner

shaise commented Sep 16, 2018

Yes, I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants