Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DVB image based subtitle are not rendering using SMPTE-TT in the latest version V4.2.0 and V4.1.3 #4448

Closed
balajic7 opened this issue Aug 29, 2022 · 2 comments
Closed

DVB image based subtitle are not rendering using SMPTE-TT in the latest version V4.2.0 and V4.1.3 #4448

balajic7 opened this issue Aug 29, 2022 · 2 comments
Labels
component: TTML The issue involves TTML subtitles specifically priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.3

Comments

@balajic7
Copy link

balajic7 commented Aug 29, 2022 •
edited
Loading

Have you read the FAQ and checked for duplicate open issues?
Yes, Linked issues #4407, #4412 or #4273

What link can we use to reproduce this?
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;panel=CUSTOM%20CONTENT;build=uncompiled

What version of Shaka Player are you using?
v4.2.0-uncompiled

What browser and OS are you using?
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36

What did you do?
Tried to do playback DASH content with DVB image-based subtitle, playback happened for audio/video but the player could not render SMPTE image-based subtitle.

What did you expect to happen?
It should render image-based subtitles.

What actually happened?

Shaka-player could not render DVB png image-based subtitles on screen whereas it was working in V4.1.2, Sample XML attached in comment.
@balajic7
Copy link
Author

Sample XML attached.
image_based_subtitle.txt

@balajic7 balajic7 changed the title DVB image based subtitle are not rendering in the latest version V4.2.0 and V4.1.3 DVB image based subtitle are not rendering using SMPTE-TT in the latest version V4.2.0 and V4.1.3 Aug 29, 2022
@avelad avelad added type: bug Something isn't working correctly component: TTML The issue involves TTML subtitles specifically labels Aug 29, 2022
@github-actions github-actions bot added this to the v4.3 milestone Aug 29, 2022
@avelad avelad added the priority: P1 Big impact or workaround impractical; resolve before feature release label Aug 30, 2022
@avelad
Copy link
Member

avelad commented Aug 30, 2022

Resolved with 4a197e1

@avelad avelad closed this as completed Aug 30, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Oct 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: TTML The issue involves TTML subtitles specifically priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.3
Development

No branches or pull requests
2 participants
@avelad @balajic7