fix: Virgin Media set top box is incorrectly categorized as Apple/Safari #4678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excluding VirginMedia device from Apple platform check
|
Incremental code coverage: 83.33% |
agajassi
changed the title
joeyparrish
approved these changes
Nov 10, 2022
joeyparrish
changed the title
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue/4676
In order to get the playback working, I am excluding VirginMedia device from isApple() platform test, otherwise it incorrectly fails at isBrowserSupported().
BEGIN_COMMIT_OVERRIDE
fix: Virgin Media set top box is incorrectly categorized as Apple/Safari
END_COMMIT_OVERRIDE