fix(hls): Fix type error in lazy-loading #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a potential type error in an edge case in lib/player.js. It would have been caught by the latest compiler, so this upgrades the compiler and fixes another type error in one other place, as well.
JulianDomingo
previously approved these changes
Nov 11, 2022
|
Incremental code coverage: 100.00% |
This fixes build errors on Windows and macOS. It would seem that the compiler upgrade made this an issue within the GitHub Actions environment.
|
The compiler upgrade part of this caused an issue in GitHub Actions, where the macOS & Windows VMs seem to default to Java 8, but the newer compiler requires Java 11. The fix for that (which I'm still waiting for results on) dismissed @JulianDomingo's review. :-( |
avelad
added
type: bug
avelad
approved these changes
Nov 11, 2022
theodab
approved these changes
Nov 11, 2022
joeyparrish
added a commit
that referenced
this pull request
Dec 8, 2022
There was a potential type error in an edge case in lib/player.js. It would have been caught by the latest compiler, so this upgrades the compiler and fixes another type error in one other place, as well.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a potential type error in an edge case in lib/player.js. It would have been caught by the latest compiler, so this upgrades the compiler and fixes another type error in one other place, as well.