Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix bufferBehind setting broken by image segments #4718

Merged
merged 2 commits into from
Nov 17, 2022
Merged

fix: Fix bufferBehind setting broken by image segments #4718

merged 2 commits into from
Nov 17, 2022

Conversation

littlespex
Copy link
Contributor

@littlespex littlespex commented Nov 16, 2022 •
edited
Loading

Resolves #4717

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format labels Nov 16, 2022
@avelad avelad added this to the v4.4 milestone Nov 16, 2022
@avelad
Copy link
Member

avelad commented Nov 16, 2022

@littlespex can you add some test? Thanks!

@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@littlespex
Copy link
Contributor Author

littlespex commented Nov 16, 2022 •
edited
Loading

Added a test.

@joeyparrish joeyparrish changed the title fix: Ignore image segment templates when updating maxSegementDuration fix: Fix image segments confusing segment duration data Nov 17, 2022
@joeyparrish joeyparrish changed the title fix: Fix image segments confusing segment duration data fix: Fix bufferBehind setting broken by image segments Nov 17, 2022
@joeyparrish joeyparrish merged commit cd1b7c0 into main Nov 17, 2022
@joeyparrish joeyparrish deleted the issue/4717-buffer-behind-image-adaptation branch November 17, 2022 17:17
@joeyparrish
Copy link
Member

@littlespex, next time, please make PRs from your fork instead of pushing branches to the main repo.

@github-actions github-actions bot mentioned this pull request Nov 17, 2022
Merged
joeyparrish pushed a commit that referenced this pull request Dec 8, 2022
@littlespex @joeyparrish
fix: Fix bufferBehind setting broken by image segments (#4718)
0e813a1 
Resolves #4717
@github-actions github-actions bot mentioned this pull request Dec 8, 2022
Merged
joeyparrish pushed a commit that referenced this pull request Dec 8, 2022
@littlespex @joeyparrish
fix: Fix bufferBehind setting broken by image segments (#4718)
2987451 
Resolves #4717
@github-actions github-actions bot mentioned this pull request Dec 8, 2022
Merged
joeyparrish pushed a commit that referenced this pull request Dec 8, 2022
@littlespex @joeyparrish
fix: Fix bufferBehind setting broken by image segments (#4718)
f9121b5 
Resolves #4717
@github-actions github-actions bot mentioned this pull request Dec 8, 2022
Merged
joeyparrish pushed a commit that referenced this pull request Dec 8, 2022
@littlespex @joeyparrish
fix: Fix bufferBehind setting broken by image segments (#4718)
54f7a5c 
Resolves #4717
@github-actions github-actions bot mentioned this pull request Dec 8, 2022
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad approved these changes

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

bufferBehind is being overridden by image adaptation set's segment duration
3 participants
@littlespex @avelad @joeyparrish