fix(cea): Fix not rendering CEA-608 on encrypted mp4 segments #4756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
# Conflicts: # lib/media/closed_caption_parser.js
joeyparrish
requested changes
Nov 30, 2022
avelad
force-pushed
the
cea-608-mp4-encrypted
branch
from
8e65a8d to
dbe7215
Compare
avelad
force-pushed
the
cea-608-mp4-encrypted
branch
from
dbe7215 to
cc8c047
Compare
|
@avelad, if you agree to these changes, we can merge. Also, please test with your content to make sure it's working correctly for you. A new test case would be nice, but I don't know how complicated that would be for you and your content. |
joeyparrish
previously approved these changes
Dec 1, 2022
joeyparrish
previously approved these changes
Dec 1, 2022
|
I agree with the changes. Thanks! |
joeyparrish
approved these changes
Dec 1, 2022
joeyparrish
added a commit
that referenced
this pull request
Dec 8, 2022
Fixes #4605 Co-authored-by: Joey Parrish <joeyparrish@google.com>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4605