Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to shakapacker gem #27

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Update to shakapacker gem #27

merged 1 commit into from
Jan 19, 2022

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Jan 19, 2022

This change is Reviewable


return resultConfig;
return resultConfig
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are needed if you're using React JSX.

}
}

module.exports = envSpecificConfig()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have a single configuration file.

Here's the shim for loading the older style of a file per value of NODE_ENV, the:

  • /config/webpack/test.js
  • /config/webpack/development.js
  • /config/webpack/production.js

},
"devDependencies": {
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.1",
"fork-ts-checker-webpack-plugin": "^6.0.1",
"react-refresh": "^0.9.0",
"webpack-dev-server": "^4.2.1"
"webpack-dev-server": "^4.7.3"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run the command:

  yarn add @babel/core @babel/plugin-transform-runtime @babel/preset-env @babel/runtime babel-loader compression-webpack-plugin pnp-webpack-plugin terser-webpack-plugin webpack webpack-assets-manifest webpack-cli webpack-merge webpack-sources webpack-dev-server

Copy link
Contributor

@Judahmeek Judahmeek Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justin808 when? why? To accomplish what?

@justin808 justin808 merged commit b3e2415 into master Jan 19, 2022
@justin808 justin808 deleted the justin808/use-shakapacker branch January 19, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants