Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe delimiter in files disables ability to clone gist #793

Closed
tillig opened this issue Mar 6, 2019 · 1 comment
Closed

Pipe delimiter in files disables ability to clone gist #793

tillig opened this issue Mar 6, 2019 · 1 comment

Comments

@tillig
Copy link

tillig commented Mar 6, 2019

🐛 Describe the bug
Usually you can fork and clone gists just like any other git repo. This is useful in cases like #756 where an upload corrupts settings and you want to try and roll back to a previous settings version.

However, files stored in child folders (like snippets) are done so by naming the file using a pipe delimiter:

Pipe delimiter in filename

The web UI for a gist doesn't have enough to allow reverting; but you also can't clone the gist with git and do a rollback that way because git won't allow you to put a filename with a pipe in it down into the filesystem. You're stuck.

It'd be nice if the delimiter was something that could be put into the filesystem so in times when the gist needs to be cloned or manipulated with git that would be possible.

🌴 Visual Studio Code Version : 1.31.1
🌴 Code Settings Sync Version : 3.2.7
🌴 Standard or Insiders : Standard
🌴 OSS or Portable : OSS
🌴 Operating System : Windows 10
🌴 Occurs On: Download
🌴 Proxy Enabled: No

📰 To Reproduce
Steps to reproduce the behavior:

  1. Create a custom snippet.
  2. Upload settings to your gist.
  3. Try cloning the gist using the GitHub instructions
  4. Git fails due to the pipe in the filename.
@shanalikhan
Copy link
Owner

Actually for reverting and other things, Settings Sync will have #413 feature.
So for GIST, I am not looking to improve ,rather move to git sync instead of gist sync.

So closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants