Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pragma removes '//' from value when uncommenting #863

Closed
chodyo opened this issue Apr 25, 2019 · 1 comment
Closed

Pragma removes '//' from value when uncommenting #863

chodyo opened this issue Apr 25, 2019 · 1 comment

Comments

@chodyo
Copy link

chodyo commented Apr 25, 2019

🐛 Describe the bug
If an uncommented pragma value contains the text //, the // is removed from the value.

For example, if a URL with protocol has a value of http://example.com, it will be uploaded to the remote gist with a value of http:example.com.

🌴 Visual Studio Code Version : [ 1.33.1 ]
🌴 Code Settings Sync Version : [ 3.2.9 ]
🌴 Standard or Insiders : [ Standard ]
🌴 Portable or Installed : [ Installed ]
🌴 OSS or Official Build : [ Official ]
🌴 Operating System : [ Windows 10 ]
🌴 Occurs On: [ Upload ]
🌴 Proxy Enabled: [ Yes ]
🌴 Gist Id: [ n/a ]

📰 To Reproduce
Steps to reproduce the behavior:

  1. Create a pragma that in use by the current machine pragma settings. It should be uncommented and contain // somewhere in the json's value.
  2. Upload settings
  3. Check uploaded value (view on web or force download). // is now missing from the key.

💪 Expected behavior
Keys should never be modified on upload or download.

📺 Console Error Log
n/a

📺 Additional context

// local settings
{
    // @sync host=home-desktop-pc
//    "http.proxy": "",
    // @sync host=work-laptop
    "http.proxy": "http://127.0.0.1:8888"
}
// remote upload
{
    // @sync host=home-desktop-pc
    "http.proxy": "",
    // @sync host=work-laptop
    "http.proxy": "http:127.0.0.1:8888"
}
@shanalikhan
Copy link
Owner

Duplicate of #865

@shanalikhan shanalikhan marked this as a duplicate of #865 May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants