From 4377e43ce570501b61f00db051fdcdda9193c246 Mon Sep 17 00:00:00 2001 From: "K. Shankari" Date: Mon, 26 Aug 2024 23:10:41 -0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A5=20Remove=20the=20pinned=20npm=20ve?= =?UTF-8?q?rsion;=20use=20the=20node=20default?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We had a pinned npm version, but we didn't actually use it, using the default version in node instead. As long as we have a reasonbly recent version of node, that seems like it will work. It is still pinned (just pinned implicitly by the node pin), and we don't actually use the pinned version now anyway. Yay for simplicity and not keeping bitrotted code around... --- setup/activate_shared.sh | 3 --- setup/export_shared_dep_versions.sh | 1 - setup/setup_shared.sh | 8 -------- 3 files changed, 12 deletions(-) diff --git a/setup/activate_shared.sh b/setup/activate_shared.sh index 40f0c3fe7..1e46c9579 100644 --- a/setup/activate_shared.sh +++ b/setup/activate_shared.sh @@ -7,6 +7,3 @@ echo "Activating nvm" echo "Using version $NODE_VERSION" nvm use $NODE_VERSION - -CURR_NPM_VERSION=`npm --version` -echo "npm version = $CURR_NPM_VERSION" diff --git a/setup/export_shared_dep_versions.sh b/setup/export_shared_dep_versions.sh index 072977560..49d062a8b 100644 --- a/setup/export_shared_dep_versions.sh +++ b/setup/export_shared_dep_versions.sh @@ -1,6 +1,5 @@ export NVM_VERSION=0.40.0 export NODE_VERSION=20.9.0 -export NPM_VERSION=10.8.2 # make sure that this is a stable version from # so that https://github.com/postmodern/ruby-versions # ideally, this would be the same version as the CI diff --git a/setup/setup_shared.sh b/setup/setup_shared.sh index c47e892dd..53be485e6 100644 --- a/setup/setup_shared.sh +++ b/setup/setup_shared.sh @@ -12,11 +12,3 @@ echo "Setting up the variables to run nvm" echo "Installing the correct node version" nvm install $NODE_VERSION - -echo "Check the version of npm" -CURR_NPM_VERSION=`npm --version` -if [ $CURR_NPM_VERSION != $NPM_VERSION ]; -then - echo "Invalid npm version, expected $NPM_VERSION, got $CURR_NPM_VERSION" - npm install npm@$NPM_VERSION -fi