Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do *not* parse arguments in PAGER #430

Closed
sharkdp opened this issue Nov 25, 2018 · 1 comment · Fixed by #454
Closed

Do *not* parse arguments in PAGER #430

sharkdp opened this issue Nov 25, 2018 · 1 comment · Fixed by #454
Labels
feature-request New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sharkdp
Copy link
Owner

sharkdp commented Nov 25, 2018

We recently introduced command-line argument parsing for PAGER and BAT_PAGER and it's been causing some problems, because some people have set PAGER="less -X" (or similar) without including the -R argument which is needed in order for bat to work with less (enables parsing of ANSI sequences).

I think we should disable parsing of command line arguments for PAGER again but leave it for BAT_PAGER. If someone has PAGER="less -X" set, we should fall back to the default behavior (use less with -FRX).
@sharkdp sharkdp added feature-request New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Nov 25, 2018
@sharkdp sharkdp mentioned this issue Nov 25, 2018
Closed
@majecty majecty mentioned this issue Dec 17, 2018
Merged
@sharkdp
Copy link
Owner Author

sharkdp commented Feb 8, 2019

Fixed in v0.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not parse arguments in PAGER majecty/bat
1 participant
@sharkdp