-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary file rename: any preference? #656
Comments
I'm 100% for parameterizing the name and docs for bat to make packaging easier on distro package maintainers. Based on a quick look at the CI scripts, the file names for the manpage and binary look like they are capable of being parameterized. The contents of the manpage do not, however. We would probably need some cross-platform preprocessor or template generator to keep building consistent between Windows and Linux. I'm not sure, but maybe there's something already built into Cargo to achieve this already? If that's overkill, I can always hack up a Bash/sed and PowerShell script to do a simple find and replace until we have the need for something more complex. @sharkdp, your opinion? |
@paride Thank you very much for bringing this discussion here and for maintaining the Debian package!
Oh, that is unfortunate 🙁.
There are also command-line variables named To be honest, I still don't quite understand why the Debian/Ubuntu policies are so strict in this regard. I know I've asked this before, but would it be so bad for users to mark the two packages as conflicting? I obviously knew that there was a high chance of clashes when I initially named this |
Hi @sharkdp,
I think it would be enough to change the two USAGE lines in the manpage and the manpage title (see below: I think there is no need to rename the project, but just the binary). A preprocessing step should allow this (e.g.
Personally I'd leave these are they are. The project is still named "bat" after all, so the config files and references to the project are fine with using bat/BAT in my opinion.
I know, this is very unfortunate.
There at least a couple of good points in favor of this policy:
This said, I agree with you: the policy is probably too strict and should give more freedom on this point to the package maintainer. Thing is: the policy isn't going to change, we have to live with it. |
@paride Thank you for taking the time to explain this in detail!
I hadn't thought of this. If there is no way around this, I think
Okay, let's work on the tooling in #659 and discuss the binary name in this ticket. |
As it seems that we're both +1 for |
It looks like the https://packages.debian.org/sid/bat |
It needs to be, the current package violates the Debian policy. See this bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=934850 It's a severity: Serious bug, meaning that the current version of the package won't migrate to testing and thus won't be part of the next Debian stable release. |
Ok, thank you. I just thought it was interesting that Ubuntu stable actually has a |
@paride It makes no sense a package named "bat" has a binary named "batcat". Suggest renaming package to "batcat", or letting this package own "bat". Think intuitive for users. |
I too found it confusing that the package is named "bat" but the binary is named "batcat", IMO the package should also be named batcat |
Hi, Debian maintainer of the
bat
package here.As the
bat
binary name is already taken in Debian by thebacula-console-qt
package, I'll have to rename thebat
binary from this project and its manpage. At some point change will affect Ubuntu too. I read in #164 that you don't intend to rename it upstream, however: do you have any preference for the alternative name? I was thinking ofbatcat
.The same happened with https://github.com/sharkdp/fd/, unfortunately. While the rename itself is not problematic, the manpage won't be consistent with the new tool's name, so the solution is quite far from being ideal. Parametrizing the tool name would produce a better result.
The text was updated successfully, but these errors were encountered: