Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented LLVM syntax highlighting and regression tests #1778

Closed
wants to merge 1 commit into from
Closed

Implemented LLVM syntax highlighting and regression tests #1778

wants to merge 1 commit into from

Conversation

ioncodes
Copy link
Contributor

@ioncodes ioncodes commented Aug 3, 2021

This PR implemented LLVM IR syntax highlighting as per #1777. Let me know if this change would be beneficial and I'll add it to the CHANGELOG.md!

@ioncodes
Copy link
Contributor Author

ioncodes commented Aug 3, 2021

Here's a screenshot of what it looks like: image

@keith-hall
Copy link
Collaborator

keith-hall commented Aug 3, 2021

Hi, nice that you worked on a syntax definition for a language you are interested in and shared it here - thanks! :)

I have a question - did you consider maintaining it in a separate repository? The reason I ask is, if/when it becomes popular, I can foresee that we may see lots of issues about it or PRs relating to improving it*, and it would be nice to be able to just bump a git submodule rather than have lots of noise in this repo

EDIT: *to clarify, there's nothing wrong with what you've done, there's just always room for improvement in my experience, especially when others start using it :D

@ioncodes
Copy link
Contributor Author

ioncodes commented Aug 3, 2021

I could definitely do that! Would you like me to close this PR and make a new repo with the syntax file and then submit a PR with that submodule added to 02_Extras or just wait it out until it receives some traffic first?

@keith-hall
Copy link
Collaborator

Up to you :) It may make sense to wait and see what others think, but the good news is we've added some syntax definitions recently which don't meet the 10k package control requirement (i.e. #1685 (comment)), and we are working on performance improvements so that having a large number of syntaxes should be less of a problem. But I certainly think we're more likely to agree to add another submodule than a sublime-syntax directly :)

@ioncodes ioncodes closed this Aug 3, 2021
@vzaliva
Copy link

vzaliva commented Sep 2, 2021

I am working with LLVM a lot and would like to be able to use this syntax highlighting. How can I do this? I have bat version 0.18.2.
Can I install additional syntax locally?

@ioncodes
Copy link
Contributor Author

ioncodes commented Sep 3, 2021

@vzaliva

The way I did it was:

  1. Pull my commit (make sure to fetch all submodules)
  2. bash assets/create.sh
  3. cargo install --path . --locked --force

This creates a new syntax blob and compiles bat with it. It will also install bat (and overwrite your current one I'd assume) globally.

If that doesn't work let me know. If it's urgent you can reach out to me on Twitter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants