Add Requirementstxt.sublime-syntax and its test.

[Freed-Wu]

❯ syntest assets/syntaxes/02_Extra/syntax_test_requirements.txt assets/syntaxes/02_Extra/Requirementstxt.sublime-syntax
loading syntax definitions from assets/syntaxes/02_Extra/Requirementstxt.sublime-syntax
Testing file assets/syntaxes/02_Extra/syntax_test_requirements.txt
The test file references syntax definition file: Requirementstxt.sublime-syntax
Ok(Success(850))
exiting with code 0

https://github.com/raimon49/requirements.txt.vim/tree/master/examples/requirements.txt

[sharkdp]

Thank you very much. We used to have requirements.txt support, but the license was not compatible. This syntax seems fine. Can you please read through https://github.com/sharkdp/bat/blob/master/doc/assets.md and add bat-style syntax tests?

[Freed-Wu]

Fixed.

[sharkdp]

Please also read the part about adding the upstream syntax as a submodule: https://github.com/sharkdp/bat/blob/master/doc/assets.md#adding-new-builtin-languages-for-syntax-highlighting

And remove assets/syntaxes/02_Extra/syntax_test_requirements.txt.

[Freed-Wu]

OK, removed.

[sharkdp]

But we still don't have the upstream syntax as a submodule, right?

[Freed-Wu]

But we still don't have the upstream syntax as a submodule, right?

You mean I should create a new github repo and create a git submodule in this repo, right?

[sharkdp]

But we still don't have the upstream syntax as a submodule, right?

You mean I should create a new github repo and create a git submodule in this repo, right?

Oh, I didn't realize you created this syntax. I saw the link to https://github.com/raimon49/requirements.txt.vim/tree/master/examples/requirements.txt and didn't realize it was a vim syntax, not a Sublime Text syntax. In this case, I'm okay with integrating it into bat directly, but maybe in its own subfolder (where you can also add the sublime syntax test, sorry 😄). But having it in a separate repository would also be great. Whatever you prefer.

[Freed-Wu]

you can also add the sublime syntax test, sorry

No serious 😄

maybe in its own subfolder

Why not create a subfolder for every *.sublime-syntax?
Now in assets/syntaxes/02_Extra, folder and file exist at the same time. It looks not very tidy.

[sharkdp]

Now in assets/syntaxes/02_Extra, folder and file exist at the same time. It looks not very tidy.

We do have folders for all submodules. But for some of them we need a manually converted .sublime-syntax file, because they only support .tmLanguage. If the syntax has a .sublime-syntax in the module itself, there is no additional file.

[Freed-Wu]

there is no additional file.

I see. If a sublime-syntax has additional file, It will create a subfolder. So should we create a folder for them?

$ ls assets/syntaxes/02_Extra/syntax_test_*
 assets/syntaxes/02_Extra/syntax_test_csv.csv
 assets/syntaxes/02_Extra/syntax_test_man.man
 assets/syntaxes/02_Extra/syntax_test_tsv.tsv

[sharkdp]

Sorry, I wasn't aware that we had some syntax tests in assets/syntaxes/02_Extra. In that case, let's merge this as is. We can always clean up later.

Thank you very much.