Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab Smart Links Markdown Conversion Issue #17

Closed
corbetmw opened this issue May 31, 2022 · 5 comments
Closed

Gitlab Smart Links Markdown Conversion Issue #17

corbetmw opened this issue May 31, 2022 · 5 comments

Comments

@corbetmw
Copy link
Contributor

When using Gitlab links in Jira comments, the link is broken when the Jira Cloud Slack app creates a Slack message for it. Please see the other reports listed below:

  1. https://jira.atlassian.com/browse/JRACLOUD-76111
  2. https://community.atlassian.com/t5/Jira-Software-questions/Jira-Cloud-bot-messages-are-rewriting-the-content-and-breaking/qaq-p/2028835

The root cause is this regex replace in index.js. At this replace, it's parsing the Smart Link formatting of the link, which replaces the dashes as tildes. Please see this example for more detail.

@corbetmw
Copy link
Contributor Author

Resolved in most recent PR.

@shaunburdick
Copy link
Owner

Thank you for your contributions @corbetmw I have pushed a new version with your fixes in it!

@corbetmw
Copy link
Contributor Author

Thanks, @shaunburdick . Any way we can get this published to NPM?

@shaunburdick
Copy link
Owner

@corbetmw
Copy link
Contributor Author

Oh, weird! I wasn't seeing it in the versions list. Thank you!
Screen Shot 2022-05-31 at 6 20 10 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants