Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing shortcode inserts nested shortcode #11

Open
wernerkrauss opened this issue Mar 12, 2015 · 4 comments
Open

Editing shortcode inserts nested shortcode #11

wernerkrauss opened this issue Mar 12, 2015 · 4 comments

Comments

@wernerkrauss
Copy link
Contributor

Hi,
on SS 3.1.10 and Shortcodable v 0.1.1 5fbf1f8 when i click to edit an existing shortcode i see all data in the form (and heading: Edit Shortcode), but when i click on "insert shortcode" i get a nested shortcode:

before: [Webcam id=2 title="Foo"]
after: [Webcam id=2 t[Webcam id="2" title="Bar"]itle="Foo"]

@sheadawson
Copy link
Owner

Yeah I see, this needs fixing! I'm a bit limited on time at the moment but will have a look at it as soon as I can. If it helps in the mean time, you can select/highlight the existing shortcode text then click to edit, which works fine.

@wernerkrauss
Copy link
Contributor Author

ping.... any improvement on this issue?

@sheadawson
Copy link
Owner

No movement on this sorry I just haven't had time to look at it. Hoping someone can send in a PR for this

@sheadawson
Copy link
Owner

The new placeholders will help with this but still need to fix shortcodes that don't have placeholders https://github.com/sheadawson/silverstripe-shortcodable/tree/2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants