Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow in webpack 5 #244

Closed
domarmstrong opened this issue Jan 16, 2021 · 1 comment · Fixed by cstorey/blogue#188, electron/electronjs.org-old#5223 or coderan-io/ui-legacy#65
Closed

Comments

@domarmstrong
Copy link

  • Manifest Plugin Version: 3.0.0

Expected Behavior / Situation

Plugin is fast

Actual Behavior / Situation

Plugin is slow

Modification Proposal

Hi. I've found that our webpack rebuild time is quite slow when upgrading to webpack 5. One of the reasons seems to be the call to stats.toJson in emitHook. I noticed that all: false is commented out in 2702efb#diff-9c0b469fe528c4695452cbd66ea7ba2845b967ff897481f6e0d66c4d963cbfccR42, adding this back in dramatically increases the processing time. Was there a reason this was commented out, or can it be added back? I see no adverse affects in our build by enabling it again.

// all: false commented out
stats: 1.697s
// all: false enabled
stats: 12.53ms
@domarmstrong
Copy link
Author

Awesome, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment