Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making changes to theme always asks for restart #957

Closed
shiftkey opened this issue Nov 27, 2023 · 1 comment · Fixed by #980
Closed

making changes to theme always asks for restart #957

shiftkey opened this issue Nov 27, 2023 · 1 comment · Fixed by #980
Labels
help wanted

Comments

@shiftkey
Copy link
Owner

shiftkey commented Nov 27, 2023 •
edited
Loading

Spotted while testing 3.3.5 but may be present in previous releases.

Repro steps:

  1. Launch app, open settings
  2. Without making any changes, press Save

Expected: no prompt to restart app
Actual: app seems to always ask for restart

Possibly related to #912 but I can't recall seeing this at the time so it might be a new regression.
@krushnaj
Copy link

krushnaj commented Nov 27, 2023 •
edited
Loading

I did downgrade to 3.3.3 and it happens on that version too. Will downgrade further to see if it happens on other versions or not.

Tested this on 3.3.1 and it just as you mentioned it happens due to that change.

@shiftkey shiftkey mentioned this issue Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
2 participants
@shiftkey @krushnaj