ANSI renderer bg color not showing

[KevinBatdorf]

I was messing around with the ansi renderer and It's not rendering well in some cases (maybe with the background only?). Using the test content too.

[octref]

Can you please include the ANSI sequence in plaintext, the color expected and the color rendered?

[KevinBatdorf]

The top section I grabbed it from the test suite here: https://github.com/shikijs/shiki/blob/main/packages/shiki/src/__tests__/ansi.test.ts#L6

It should look like this (dracula terminal theme):

But looks like this (dracula shiki theme):

The bg color behind WARN is the issue

Exact snippet from my screenshots:

�[0;32;1m❯�[0m �[0;32mpnpm�[0m install --force�[0m
�[0;30;43m WARN �[0m using --force I sure hope you know what you are doing�[0m
Scope: all 6 workspace projects�[0m
Lockfile is up to date, resolution step is skipped�[0m
Packages: �[0;32m+1038�[0m�[0m
�[0;32m++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++�[0m

[octref]

i'll take a look later but also @muenzpraeger

[muenzpraeger]

Just ran a quick test. The tokens are correctly identified.

{
  value: ' WARN ',
  foreground: { type: 'named', name: 'black' },
  background: { type: 'named', name: 'yellow' },
  decorations: Set(0) {}
}

Now the thing is that the ANSI tokenizer returns only a single color property. So the background color doesn't get passed back to the HTML rendering.

[octref]

IThemedToken will have a bgColor in 1.0's API.

[blake-mealey]

Currently shiki's theme token doesn't support background colors so for the ANSI implementation I just left it out. Was thinking about coming back to this. ANSI also supports strikethrough which would be nice to add to shiki at some point.

[octref]

oops, that's right, i meant to mention @blake-mealey not @muenzpraeger, sorry!