Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No matching version found for @shikijs/twoslash@^3.1.2. #763

Closed
3 of 5 tasks
kaakaa opened this issue Aug 31, 2024 · 0 comments
Closed
3 of 5 tasks

No matching version found for @shikijs/twoslash@^3.1.2. #763

kaakaa opened this issue Aug 31, 2024 · 0 comments

Comments

@kaakaa
Copy link

kaakaa commented Aug 31, 2024

Validations

Describe the bug

When installing @slidev/cli, I encountered the following error.

$ npm i @slidev/cli                 
npm error code ETARGET
npm error notarget No matching version found for @shikijs/twoslash@^3.1.2.
npm error notarget In most cases you or one of your dependencies are requesting
npm error notarget a package version that doesn't exist.

I looked into this error, and I (maybe) found that shiki has incorrect version specification for @shikijs/twoslash .
https://github.com/shikijs/shiki/blob/main/pnpm-workspace.yaml#L22

@shikijs/twoslash doesn't have that version (3.1.2), and this issue seemed to be introduced when renaming shiki-twoslash to @shikijs/twoslash. I believe this was expressed when the pnpm catalog was introduced.
a04b3e2#diff-c82d37826e7a067e8c3ec9b11b7a2e91fce9cdda0f3298f8cfcd6bf3ab5c0a70R64

I think that removing @shikijs/twoslash from pnpm-workspace.yaml would be fix this issue(, but I'm not sure that it is the correct patch for this because I don't understand why packages/twoslash/package.json have a dependency to @shikijs/twoslash).

Reproduction

npm init -y && npm i @slidev/cli

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant