Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontStyle and background are missed when working with monaco editor #848

Closed
4 of 5 tasks
lejunyang opened this issue Nov 27, 2024 · 0 comments · Fixed by #849
Closed
4 of 5 tasks

fontStyle and background are missed when working with monaco editor #848

lejunyang opened this issue Nov 27, 2024 · 0 comments · Fixed by #849

Comments

@lejunyang
Copy link
Contributor

Validations

Describe the bug

we can see "export default" is italic style in material-theme-darker theme, while in reproduction, there is no italic style
image

I think fontStyle and background are missed from below

if (settings.foreground && s) {
rules.push({
token: s,
foreground: normalizeColor(settings.foreground),
})
}

Reproduction

https://codepen.io/lejunyang/pen/xbKKwQO

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant