Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Add children field for React 18 #637

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

andersaamodt
Copy link
Contributor

@andersaamodt andersaamodt commented May 22, 2022

Closes #639

@@ -14,6 +14,7 @@ export interface ShepherdOptionsWithType extends Step.StepOptions {
interface ShepherdProps {
steps: Array<ShepherdOptionsWithType>;
tourOptions: Tour.TourOptions;
children?: ReactNode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
children?: ReactNode
children?: ReactNode
Suggested change
children?: ReactNode
children?: ReactNode;

@RobbieTheWagner RobbieTheWagner added the bug Something isn't working label May 24, 2022
@netlify
Copy link

netlify bot commented Jul 5, 2022

Deploy Preview for upbeat-mahavira-374bd8 ready!

Name Link
🔨 Latest commit b11d50a
🔍 Latest deploy log https://app.netlify.com/sites/upbeat-mahavira-374bd8/deploys/62c4aa039ae13300081b5f7e
😎 Deploy Preview https://deploy-preview-637--upbeat-mahavira-374bd8.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@monshan
Copy link
Contributor

monshan commented Jul 5, 2022

Closes #639

@rwwagner90 This is good to merge!

@RobbieTheWagner RobbieTheWagner merged commit b2bdd59 into shepherd-pro:master Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[React18] Missing children property on ShepherdProps
3 participants