Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove operator-sdk dependencies in application code #584

Closed
adambkaplan opened this issue Feb 9, 2021 · 3 comments
Closed

Remove operator-sdk dependencies in application code #584

adambkaplan opened this issue Feb 9, 2021 · 3 comments
Assignees
@HeavyWombat @qu1queee
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Milestone
release-v0.4.0

Comments

@adambkaplan
Copy link
Member

We have several instances where we invoke operator-sdk libraries that were removed in v1.x. These should be replaced with appropriate equivalents.

This includes:

  1. operator-sdk/pkg/log/zap - can be replaced with sigs.k8s.io/controller-runtime/pkg/log/zap
  2. operator-sdk/pkg/metrics - could be replaced with sigs.k8s.io/controller-runtime/pkg/metrics
  3. operator-sdk/pkg/ready- could be replaced with sigs.k8s.io/controller-runtime/pkg/healthz
  4. operator-sdk/pkg/test - There is no controller-runtime equivalent. We may have to replace with our own logic.
@adambkaplan adambkaplan added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 9, 2021
This was referenced Feb 9, 2021
Merged
Closed
@sbose78
Copy link
Member

sbose78 commented Feb 9, 2021

👍

@qu1queee qu1queee added this to the release-v0.4.0 milestone Feb 19, 2021
@qu1queee qu1queee mentioned this issue Feb 19, 2021
Merged
3 tasks
@HeavyWombat HeavyWombat mentioned this issue Feb 19, 2021
Merged
3 tasks
@qu1queee
Copy link
Contributor

qu1queee commented Feb 22, 2021 •
edited
Loading

FYI, we are already working on this.

@HeavyWombat HeavyWombat mentioned this issue Feb 22, 2021
Merged
3 tasks
@qu1queee qu1queee mentioned this issue Feb 22, 2021
Closed
@qu1queee
Copy link
Contributor

Im closing this one, done via:

@HeavyWombat HeavyWombat mentioned this issue Mar 1, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HeavyWombat HeavyWombat

@qu1queee qu1queee

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
release-v0.4.0
Development

No branches or pull requests
4 participants
@sbose78 @adambkaplan @HeavyWombat @qu1queee