Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

May be you should remove dummy user with id 0? #37

Open
hitochan777 opened this issue Jan 24, 2018 · 1 comment
Open

May be you should remove dummy user with id 0? #37

hitochan777 opened this issue Jan 24, 2018 · 1 comment

Comments

@hitochan777
Copy link
Contributor

In infra/inmemory/users.go, it registers a dummy user with id = 0. But, because User#NotExist returns true when user ID = 0, this user is useless. (I guess you use id 0 temporarily when creating a user?)
Maybe you should change the id to 1 or something else?
@mzki
Copy link
Collaborator

mzki commented Jan 26, 2018

It is a historical reason. Dummy user with id = 0 was used by testing but is no longer used.

I will remove it later. Thanks to point out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hitochan777 @mzki