Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows builds fail for PHP 8.1 #489

Closed
2 of 5 tasks
driesvints opened this issue Sep 2, 2021 · 8 comments
Closed
2 of 5 tasks

Windows builds fail for PHP 8.1 #489

driesvints opened this issue Sep 2, 2021 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@driesvints
Copy link

Describe the bug
Windows builds are currently failing for the PHP 8.1 nightly builds at the setup PHP step with this library. The following error is thrown:

Screen Shot 2021-09-02 at 10 30 27

It seems a non existing PHP 8.1.0RC2-dev version is used even though that's not been released yet. We're at PHP 8.1.0 Beta3 right now: https://www.php.net/archive/2021.php#2021-08-19-1

You can see the builds fail here: https://github.com/laravel/framework/pull/38404/checks?check_run_id=3493365859

Version

  • I have checked releases, and the bug exists in the latest patch version of v1 or v2.
  • v2
  • v1

Runners

  • GitHub Hosted
  • Self Hosted

Operating systems
Microsoft Windows Server 2019

PHP versions
PHP 8.1 nightly builds

To Reproduce
This part of our GitHub Actions setup: https://github.com/laravel/framework/blob/fa1c2f51a69cbe759ffcd16ad8250ef045a6537b/.github/workflows/tests.yml#L89-L118

Expected behavior
I expect PHP 8.1 Beta 3 to be loaded but it tries to setup a non existing PHP 8.1.0RC2-dev

Additional context
I discovered this while working on a PR to fix PHP 8.1 issues in the Laravel framework's 8.x branch: laravel/framework#38404

Are you willing to submit a PR?
I'm afraid I don't know enough about this library to submit a PR.

@driesvints driesvints added the bug Something isn't working label Sep 2, 2021
@driesvints
Copy link
Author

Right after seeing this I tried re-running the main build on 8.x and it seems that all of our PHP 8.1 builds across all branches are now failing. I'll revert our PHP 8.1 builds for now so pull requests from community members etc don't fail.

https://github.com/laravel/framework/runs/3493571398

@shivammathur
Copy link
Owner

@driesvints I have reported the bug to powershell-phpmanager package that setup-php uses for Windows.
mlocati/powershell-phpmanager#87

@driesvints
Copy link
Author

Thanks @shivammathur. I was in doubt where the issue was present but since it was happening in the shivammathur/setup-php step I reported it here. Thanks for finding the correct location.

@shivammathur
Copy link
Owner

@driesvints No worries, Till there is a fix in powershell-phpmanager, I have built PHP 8.1 with the PHP version patched to 8.1.0-dev, which is parsed correctly. So, it should work again.

@driesvints
Copy link
Author

Seems like @mlocati is already on it 🙂

@mlocati
Copy link
Contributor

mlocati commented Sep 2, 2021

I should have fixed the issue. Please keep me updated.

@shivammathur
Copy link
Owner

@mlocati Thanks, works now.

@driesvints
Copy link
Author

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants