Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileNotExist does not work #118

Closed
shoenig opened this issue Apr 5, 2023 · 2 comments · Fixed by #119
Closed

FileNotExist does not work #118

shoenig opened this issue Apr 5, 2023 · 2 comments · Fixed by #119

Comments

@shoenig
Copy link
Owner

shoenig commented Apr 5, 2023

FileNotExist does not work as expected, due to misusing the fs package, which does not expect absolute paths. When you do, you get invalid argument error.
@alessio-perugini
Copy link
Contributor

👋 Hi there, do you mind if I'll work on this?

@shoenig
Copy link
Owner Author

shoenig commented Apr 13, 2023

Go for it, @alessio-perugini !

@gulducat and I looked into this briefly - I suspect FileNotExists just needs to trim any leading /, similar to what FileExists is already doing. There might also be room to improve the test cases around this little family of functions to make sure something like this isn't missed again.

@alessio-perugini alessio-perugini mentioned this issue Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix FileNotExist func alessio-perugini/test
2 participants
@shoenig @alessio-perugini