Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compatibility to use the storefront watcher with an non empty URI #2973

Closed

Conversation

aragon999
Copy link
Contributor

@aragon999 aragon999 commented Feb 11, 2023

1. Why is this change necessary?

My APP_URL looks for example like this: http://127.0.0.1/sw/platform/public. Currently the storefront watcher fails with the message that it cannot resolve the hostname 127.0.0.1/sw/platform/public:
grafik

Additionally the URL was not correctly opened, as the protocol was missing, which is fixed by this change as well.

2. What does this change do, exactly?

Parse the URL correctly in the storefront watcher script, and include an URI.

3. Describe each step to reproduce the issue or behaviour.

Start the storefront watcher using an URL like: http://127.0.0.1/sw/platform/public.

4. Please link to the relevant issues (if any).

-

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@aragon999 aragon999 force-pushed the fix/storefront-watcher-with-uri branch from 5bc145f to b80604d Compare February 12, 2023 10:57
@shopwareBot
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-25435

Please use this issue to track the state of your pull request.

@tobiasberge
Copy link
Contributor

Hi @aragon999, thanks for your contribution. 🥳

I have tested this locally and opening the browser works well. I have imported your PR.

Just FYI: There is also an internal PR about to be merged which adds additional fixes regarding the automatic reload which is not properly working at the moment.

@tobiasberge
Copy link
Contributor

The changes were merged to trunk. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants