Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structural Analysis #56

Open
longfangsong opened this issue May 10, 2024 · 1 comment · Fixed by #59
Open

Structural Analysis #56

longfangsong opened this issue May 10, 2024 · 1 comment · Fixed by #59
Assignees
@longfangsong
Labels
feature request A request for a certain feature hard This issue is very hard to fix medium priority This will be important in the near future refactor To make the code prettier

Comments

@longfangsong
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently the wasm code gen is worked in a very unnature way.

And the code is very very very ugly.

Describe the solution you'd like

Instead of using current complex algorithm, use Structural Analysis based way instead.

We should start from creating a structural analysis analysis pass.

Ref Advanced Compiler Design & Implementation, Chapter 7.7, P202

Describe alternatives you've considered
Just refactor the current code generating.
@longfangsong longfangsong added feature request A request for a certain feature hard This issue is very hard to fix medium priority This will be important in the near future refactor To make the code prettier labels May 10, 2024
@longfangsong longfangsong self-assigned this May 10, 2024
@longfangsong longfangsong mentioned this issue Jun 27, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in 任务公告板 Jun 27, 2024
@longfangsong longfangsong reopened this Jun 28, 2024
@longfangsong
Copy link
Member Author

#59 added the analysis, but need to use it to replace the scc based code gen process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@longfangsong longfangsong

Labels
feature request A request for a certain feature hard This issue is very hard to fix medium priority This will be important in the near future refactor To make the code prettier
Projects
任务公告板
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add structural analysis longfangsong/Come
1 participant
@longfangsong