Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing settings is vulnerable to errors #9

Closed
siblount opened this issue Aug 26, 2022 · 0 comments · Fixed by #22
Closed

Parsing settings is vulnerable to errors #9

siblount opened this issue Aug 26, 2022 · 0 comments · Fixed by #22
Labels
good first issue Good for newcomers

Comments

@siblount
Copy link
Owner

Parsing settings in DPSettings.Initialize() is not caught with try...catch statements and can cause unexpected extractions nor is a warning issued to the user regarding this.

For instance, pushing a new update that includes a new setting causes Initialize() to throw an exception for the newly added settings.

@siblount siblount added the good first issue Good for newcomers label Aug 26, 2022
@siblount siblount changed the title Parsing settings is valuable to errors Parsing settings is vulnerable to errors Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant