Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong default constant used for SQSSource parameter "delete.messages" #19

Open
gspadotto opened this issue Mar 17, 2020 · 3 comments
Open

Comments

@gspadotto
Copy link

Description:
This line should use
"" + SQSConstants.DEFAULT_DELETE_AFTER_CONSUME

rather than
"" + SQSConstants.DELETE_MESSAGES_NAME

Suggested Labels:

Suggested Assignees:

Affected Product Version:

OS, DB, other environment details and versions:

Steps to reproduce:

Related Issues:

@radostin-r
Copy link

Is this an issue that would prevent the extension from keeping messages even after "delete.messages = 'false'" is set? Because this is what I am experiencing now 1 year later. I can see the messages are consumed correctly but htey are also deleted and my other consumers can't consume them even though I've set the delete flag to False.

@gspadotto
Copy link
Author

@radostin-r It might as well be, but this repository seems abandoned...

@radostin-r
Copy link

Yeah seems, so. sigh
There is no other extension for sqs is there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants