Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematic ID is not consistent due to ordering #99

Closed
onedr0p opened this issue Apr 5, 2024 · 3 comments · Fixed by #101
Closed

Schematic ID is not consistent due to ordering #99

onedr0p opened this issue Apr 5, 2024 · 3 comments · Fixed by #101
Assignees

Comments

@onedr0p
Copy link

onedr0p commented Apr 5, 2024

Schematic ID is not consistent due to rendered ordering of system extensions, it would be nice if this was consistent for reproducibility.

To reproduce:

  1. Go to https://factory.talos.dev/
  2. Select some system extensions
  3. Submit and see it generate a schematic ID
image 4. Click submit again, and again and again and notice how the ordering of the system extensions changes and so does the schematic ID image

I am curious if setting an ordering on the system extensions before the processing takes place will address this issue?

@smira
Copy link
Member

smira commented Apr 5, 2024

Order of extensions technically changes the output, as the order of extensions might matter (they are overlaid on top of another). Our extensions don't have side-effects, but still order changes the output.

You can skip using UI and use API directly for exact reproducibility.

@smira
Copy link
Member

smira commented Apr 5, 2024

But certainly we can do better job in the UI.

@onedr0p
Copy link
Author

onedr0p commented Apr 5, 2024

Thanks @smira, it's not a huge issue but might confuse some people who are not aware of this nuance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants