[Breaking change]: field.length is a string inside typeCast.

[felixmosh]

Since v2.3.2 the field.length property that passed into typeCast function is a string instead of number!

Therefore it breaks boolean conversions.

typeCast: (field, next) => {
  if (field.type === 'TINY' && field.length === 1) {
  // --------------------------------------^ this check is failing, and it breaks the app (no booleans).
    return field.string() === '1'; // 1 = true, 0 = false
  }
  return next();
}

If this change was intentional, it is a breaking change, therefore I should be bumped in a major version.
I'm using knex query builder.

[sidorares]

@testn might be another regression related to #1402

[testn]

let me take a look.

[sidorares]

I'm surprised how many users depend on typeCast, was going to deprecate it relatively soon in favour of "value mapping" option higher in the stack ( e.i after all deserealisation is already done )

[sidorares]

@felixmosh could you test by installing from master?

[testn]

I'm surprised how many users depend on typeCast, was going to deprecate it relatively soon in favour of "value mapping" option higher in the stack ( e.i after all deserealisation is already done )

I agree. But you might need to come up with the specification?

[sidorares]

yeah, I'll try to create RFC with proposed spec

[felixmosh]

@felixmosh could you test by installing from master?

Looks OK to me.

[testn]

@felixmosh, let's close this?

[jclvicerra]

Seems already fixed in the release 2.3.3