Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl From<T> for JsValue where T: IntoWasmAbi using tsify #21

Closed
Pantamis opened this issue Apr 11, 2024 · 1 comment · Fixed by #22
Closed

impl From<T> for JsValue where T: IntoWasmAbi using tsify #21

Pantamis opened this issue Apr 11, 2024 · 1 comment · Fixed by #22

Comments

@Pantamis
Copy link

Hi,

I wanted to propose a PR to do it but I see you are going through the milestone of publishing your fork as a crate which is great, thank you 👍 ! On which branch should I do my PR to not mess up anything you are working on currently to keep it clean ?

This change is useful when you want to return a Tsify type in a async function to export it as a Promise<T> using wasm-bindgen-futures.

This is a really short change to code and review feel free to code it yourself and ping me for a review !
@Pantamis Pantamis changed the title impl From<T> for JsValue where T: IntoWasmAbiusing tsify impl From<T> for JsValue where T: IntoWasmAbi using tsify Apr 11, 2024
@Pantamis Pantamis mentioned this issue Apr 11, 2024
Merged
@Pantamis
Copy link
Author

Pantamis commented Apr 11, 2024 •
edited
Loading

Done in #22. Feel free to rebase it on another branch !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: impl From<T> for JsValue where T: IntoWasmAbi + Tsify Pantamis/tsify
1 participant
@Pantamis