-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media Not Exporting to XML #1619
Comments
Didn't realize SMS B&R supported media now. Maybe @McLoo can take this on. |
@moxie not until next weekend. Got to figure out how media is exported. I guess Base64. |
Has this been resolved? |
@McLoo check out the |
@McLoo im trying not to nag... but is there any news regarding this? I'm waiting for that feature for some reason ;-) |
@diego0815 just go on nagging. I always need some trigger ;) I was waiting for @mcginty to finish the makeover of the export process to go on. I guess I could at least go for the import part already... |
@McLoo that sounds great, yepp I also sometimes need this kick in the ass, just feeling bit bad nagging guys who are doing such great things in their spare time ;-) but as long as you appreciate an occasional nag, I'll gladly do so B-) I'm waiting for media export, so I can get my messages exported, then all wiped ( to fix 814 for me) and then re-imported... |
I put a simple dump file here that reliably fails. There are three messages in it, 2 sms, 1 mms. The mms doesn't import. http://alexlance.com/TextSecurePlaintextBackup.xml Would love to get this issue fixed so I can bring all my existing messages into textsecure. Let me know if I can provide any info or assist in any way. I also commented on #1410 which is probably a dupe of this issue. |
@alexlance MMS are totally ignored right now. The import for them has to be implemented first. So it's more a missing feature than a bug ;-) |
@McLoo may I suggest that it is very surprising behaviour for the And unfortunately after an import into textsecure the user is very Are there any plans/timeline to implement this functionality? |
@alexlance as i understand it's being worked on, and its depending on some other prerequisites. |
@diego0815 Frankly - the user that is getting software for free does not have a right to nag :) but this particular issue stops me from using textsecure as my default messager. And it might be a missing feature that it doesn't import mms, but it is a bug that it doesn't report an error to the user, saying: Hey everything was imported just fine, except these messages... Presumably the textsecure dev team have some sort of roadmap of priorities - it'd be lovely to get an indication of when (or if) textsecure will support importing mms/images. |
@alexlance totally agree lets see when we will get what we are craving for (hint @McLoo ;-) |
@McLoo any chance of getting an idea of whether this functionality will be added? |
@alexlance I wish I knew. Work is pushing me quite hard these days. To much to work on such a change right now. 😢 @mcginty what about the rewritten import/export? Dropped? |
@McLoo ok thanks for letting me know. It's such a bugger, because I would love to switch over to TextSecure and delete the system message store, but I can't just discard all the old mmses - a picture is worth a thousand words :) |
I just installed TextSecure (v 2.2.0) and love it, but was disappointed that my MMS images didn't import along with the SMS text from the Android (v 4.4.4) Messaging (v 4.4.4-24) app. I think this is the right topic to chime in and vote/beg for additional MMS functionality in TextSecure. Thanks for a great app! |
Any progress on this issue? |
sry. no more but a growing feel of shame for not touching this. |
@McLoo Nothing to be ashamed of; it is understandable that other things have more priority. Nonetheless, the import‐export feature would ease the switch from other SMS apps and would supply a nice way to comprehensively backup all messages (no loss in either case). |
+1 for this feature. I've been watching this issue for over a year, it is the only reason I have not switched to TextSecure yet. Does anyone know how SMSBackup And Restore serializes their image data? |
Very similar situation as above. I'm waiting for this feature for more than a year too. I even have two phones. I don't use the second one but I still can't wipe out all the data from it because there is a TextSecure with all my messages. (of course I could do it manually but it would take a long time I'm not willing to waste so much of it..). Possibility of backing up this type of data is very, very important and I don't really care if the backup is encrypted or not. If it is not I will just encrypt it with other tool. |
+1 |
Hi @McLoo and @mcginty and @moxie0, Australia is moving over to mandatory data retention laws soon, which will include text As this issue directly impacts users who are looking to migrate to a new messaging platform, |
+1 I would love to see this feature! |
I honestly do not know why this does not have priority. Personally I've introduced close to 10 people to Signal. They all loved it. But not a single one of them are using it anymore because after the first time they get a new phone and realize all their mms are lost this app is dead to them. So I'm now the only one using it making its encryption pointless. Honestly I'd do this myself if I could, however I have exactly zero experience coding for Android. I cannot stress enough how important this issue is, however! |
Is there an official status on the @rmgk version? Would love to see this feature and am happy to help with coding, testing, etc etc. Any chance of a road map of what is needed so those of us who find the lack of backup one of the most appalling mis-features of Signal can do something about it? |
After reading through the thread and seeing the bug is 3yrs old, I'd like to suggest a minimalist approach:
|
I'm not sure if I understand your suggestion correctly, @breznak : Should the media be part of the plaintext encryption (base64-encrypted)? Because then, the separate export of all media is not necessary. Regarding point 3, the export of all media of a conversation was once supported, but is currently not (see #7097) |
Actually that is a good idea, if it's easier! I wasn't thinking of a plaintext export of media encoded as bas64-encoding. Ad point 3: yes, all my activity was about the feature of "Save/Export All media". |
The Signal-Desktop app just transitioned from Chrome App to standalone. In the process of moving from one to another, you have to create a backup (unencrypted) that contains all messages, media and keys. Maybe @moxie0 or someone from the OWS team could give us a hint if this is worth investigating further. I do not mean to unnecessarily ping for attention but I believe that some clear guidance on what is expected for a pull request to be considered, would be a huge motivator. the OWS team wants:
The community (only my impression based on what I read):
I personally think:
I hope this helps to advance the discussions between community and OWS. |
Sounds excellent to me; I am happy to donate time and effort (coding) to this, but only if we have a genuine likelihood of whatever patch being accepted. There have been too many genuine efforts lost and discarded in the past to give me great confidence in the process. Plain text export of text and images is vastly superior to the current offering. |
No useful backup functionality is such a major drawback of Signal. Currently I don't recommend it to anyone anymore because of this. I don't understand why compatibility to SMS B&R is required, as it seems to be a huge problem. I have never heard of that app before and also don't know anyone who has. |
Is there a reason why Signal needs to export its data in a manner that is compatible with an undocumented xml format used by a proprietary application? I understand if the authors use that app and won't work on alternatives, but it seems like other solutions are rejected specifically due to incompatibility with this undocumented format. |
I'd really like to help with this, but I don't see what has to be done next. Would it be possible to summarize the steps to archive the full backup? |
Here is a community forum thread with some recent discussion: |
@stefan-schiffer those seem like separate bugs unrelated to this one. You should search for duplicates and file separate issues for each bug if you can't find any already existing. |
@Roghetti Thank you so much for your contribution! 👏 Qucikly reviewed and it looks great. Hope the PR gets the attention it deserves and will be merged soon. |
@Roghetti So happy to see someone contribute on this one. Out of curiosity, can your method be used for archiving? I.E. keeping the backup file offsite, and then using the export in a viewer outside of the Signal App? A use case example would be that I've created a Web based message viewer that allows me to go back and view old messages from Signal and Google Voice exports. |
@Fmstrat Does your solution work with the current text-backup? Maybe similar like this: https://mattj.io/sms-backup-reader-2/main Could you please post a link to your viewer? I'm very interested on an offline solution too. |
@stefan-schiffer Yes it does, but it parses the files for both SMS backup (Signal) and Hangouts (need to update for Voice) into a database. It has a lot of personal info in the code so it's been just for me. Perhaps I could debrand it for you. Please start up a conversation on https://whispersystems.discoursehosting.net vs here, though, and I'll look into it. |
@Fmstrat Thx for the info. |
I made an effort to move from WhatsApp to the signal along with my family. After realising lack of media back up, I had to revert back. Did I miss how it's done? |
@ckujau Great news, thanks! Any idea when it will come out of beta? Unfortunately I'm not in the beta program and would need the export to switch over. ;) Picking up an S9 tomorrow so won't have the S7 much longer to export. |
GitHub Issue Cleanup: |
I have noticed that when exporting a plaintext backup in the current Play Store version of the app, all media attached to messages (and perhaps even the text from messages containing media) is not included in the XML backup, even though 'SMSBackup And Restore' backs up the media with all messages properly when creating an XML backup, and can restore the same data.
Since I use both TextSecure and SMSBackup And Restore in my system to back up a record of my messaging activity, I need media to be included in my plaintext backup alongside text messages.
The text was updated successfully, but these errors were encountered: