This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

Improve stability of primitive array lifecycle #30

Open

MarcSchoenefeld opened this issue Sep 30, 2018 · 0 comments

MarcSchoenefeld commented Sep 30, 2018

curve25519-java/android/jni/curve25519-jni.c

Line 27 in 70fae57

(*env)->ReleaseByteArrayElements(env, random, privateKey, 0);

According to https://developer.android.com/training/articles/perf-jni , releasing an array requires a prior check to prevent releasing a Null pointer. There are multiple instances of this issue throughout the file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.